Fix the Acceptance Tests by running them with beaker_hypervisor: vagrant_libvirt
#390
Conversation
Fixes: 28bc41b ("migrater to beaker_puppet_helpers")
Run acceptance tests
…upstream dont exist for builds
Fedora 39, and 40 are currently supported, but 39 uses 36 puppet binary
Bump ubuntu acceptance build
Update acceptance to run on 24.04
I did a few changes and in the end I just match and existing branch, restoring
kenyon
changed the title
beaker_hypervisor: vagrant_libvirt
We need a more up to date base branch
|
Hi! I needed to update the github actions to use ubuntu 24.04 for our acceptance tests. The main reason is there is an update to the box format, and the older vagrant in ubuntu 20.04 couldnt understand the AlmaLinux metadata. Once I updated that, I needed to rework the dependencies. So we have a much newer vagrant, vagrant-libvirt. Then it started working! I was working on a dev machine with latest vagrant-libvirt and beaker-vagrant and it was working so I was a bit confused. |
|
Now just pending voxpupuli/gha-puppet#57 merger, then we can be back on main branches of all dependencies |
| "31", | ||
| "32", | ||
| "33" | ||
| "36", |
There was a problem hiding this comment.
Fedora 36 is the version before 40 that had its own releases of puppet, because of that I added it to here, but the tests dont run because of it being EOL. I guess I can remove it?
There was a problem hiding this comment.
Yes, we should remove EOL Fedora 36, in a separate pull request so that the changelog generator picks it up. 👍
| @@ -18,4 +18,6 @@ concurrency: | |||
| jobs: | |||
| puppet: | |||
| name: Puppet | |||
| uses: voxpupuli/gha-puppet/.github/workflows/basic.yml@v1 | |||
| uses: daberkow/gha-puppet/.github/workflows/beaker.yml@ubuntu24 | |||
There was a problem hiding this comment.
This will move to v3 on main repo once voxpupuli/gha-puppet#57 is merged
|
Thanks for all the work! I'm going to merge this in #392 |
Pull Request (PR) description
I continued the work of #383! I had to do some modifications to gha-puppet, and a few other small tweaks. Let me know what else we need, then I can get to working on #382 .
This Pull Request (PR) fixes the following issues
Fixes #389